Skip to content

[Bugfix][CI] Remove V0 Spec Decode CI #1656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2025
Merged

Conversation

shen-shanshan
Copy link
Collaborator

@shen-shanshan shen-shanshan commented Jul 7, 2025

What this PR does / why we need it?

To solve the error in the CI of long term test:

modelscope - ERROR - Repo JackFram/llama-68m not exists on either https://www.modelscope.cn/ or https://www.modelscope.ai/

Replace the hf model with modelscope model.

Does this PR introduce any user-facing change?

How was this patch tested?

Copy link

codecov bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.92%. Comparing base (c30ddb8) to head (4af9b3e).
Report is 95 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1656       +/-   ##
===========================================
+ Coverage   27.39%   53.92%   +26.52%     
===========================================
  Files          56       80       +24     
  Lines        6191     9964     +3773     
===========================================
+ Hits         1696     5373     +3677     
- Misses       4495     4591       +96     
Flag Coverage Δ
unittests 53.92% <ø> (+26.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shen-shanshan shen-shanshan changed the title [Bugfix][CI] Replace the model of v0 spec decode UT [Bugfix][CI] Remove V0 Spec Decode CI Jul 7, 2025
@Yikun Yikun added long-term-test enable long term test for PR ready-for-test start test by label for PR labels Jul 7, 2025
# accuracy test multi card
VLLM_USE_MODELSCOPE=True pytest -sv tests/e2e/long_term/test_deepseek_v2_lite_tp2_accuracy.py
# VLLM_USE_MODELSCOPE=True pytest -sv tests/e2e/long_term/test_deepseek_v2_lite_tp2_accuracy.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this is comment.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERROR: file or directory not found: tests/e2e/long_term/test_deepseek_v2_lite_tp2_accuracy.py

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yikun test_deepseek_v2_lite_tp2_accuracy.py has been moved out of long term test. So it should be skip now. We can add more long-term test in the future

Signed-off-by: Shanshan Shen <87969357+shen-shanshan@users.noreply.github.com>
Signed-off-by: Shanshan Shen <87969357+shen-shanshan@users.noreply.github.com>
Signed-off-by: Shanshan Shen <87969357+shen-shanshan@users.noreply.github.com>
Signed-off-by: Shanshan Shen <87969357+shen-shanshan@users.noreply.github.com>
@wangxiyuan wangxiyuan merged commit 6af35f6 into vllm-project:main Jul 9, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
long-term-test enable long term test for PR module:tests ready-for-test start test by label for PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants